[improve][broker] PIP-192: Make unload and transfer admin API functional #19538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #19525 merge. |
Demogorgon314
force-pushed
the
Demogorgon314/PIP-192-Make_unload_admin_API_functional
branch
from
6768fa6 to
3f62bd3
Compare
Demogorgon314
force-pushed
the
Demogorgon314/PIP-192-Make_unload_admin_API_functional
branch
from
3f62bd3 to
77bca64
Compare
heesung-sn
reviewed
Feb 25, 2023
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannel.java
Outdated
Show resolved
Hide resolved
...ker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/manager/UnloadManager.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java
Outdated
Show resolved
Hide resolved
heesung-sn
reviewed
Feb 28, 2023
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/StateChangeListeners.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/pulsar/broker/loadbalance/extensions/manager/StateChangeListener.java
Outdated
Show resolved
Hide resolved
heesung-sn
approved these changes
Feb 28, 2023
Demogorgon314
requested review from
Technoboy-,
codelipenghui,
gaoran10 and
mattisonchao
Merged
14 tasks
gaoran10
reviewed
Mar 1, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
Outdated
Show resolved
Hide resolved
…I_functional # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
…I_functional # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
gaoran10
approved these changes
Mar 6, 2023
|
@Technoboy- Ping. Please take a look at this PR, thinks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-192: #16691
Motivation
Currently, the unload and transfer admin API still uses the old logic when enabling the
ExtensibleLoadManager,we need to publish the message to
ServiceUnitStateChannel, and wait for its response.Modifications
This PR added a
UnloadManagerto handle the duplicate unload request and return aCompletableFutureto the caller, so we can know when the unload operation is finished.The unload and transfer admin API also been fixed, now we can support do unload when using
ExtensibleLoadManager.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Demogorgon314#11